Skip to content

chore(ci): phase out aws-sdk usage #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As described in the linked issue, this PR reduces the reliance on the soon-to-be-put-in-maintenance-mode aws-sdk (v2). The PR swaps its usage for the more modular AWS SDK v3 for JavaScript wherever possible.

The repo still has aws-sdk as dev dependency, however this has now been moved from the root level and placed in the packages/tracer package since it's now the only utility that requires this version of the SDK to support the tracer.captureAWS and tracer.captureAWSClient methods. The SDK is only used as dev dependency to provide IDE support for the integration test functions.

To validate the changes, see the unit tests below this PR as well as the successful result of this e2e test run.

Once merged this PR will close #1404.

Related issues, RFCs

Issue number: #1404

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Apr 11, 2023
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Apr 11, 2023
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Apr 11, 2023
@dreamorosi dreamorosi merged commit 67c4b98 into main Apr 11, 2023
@dreamorosi dreamorosi deleted the chore/offload_aws_sdk_v2 branch April 11, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: decrease aws-sdk usage
1 participant